Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Spectrogram to utilizing pre-signed URLS #19

Closed
BryonLewis opened this issue Jan 20, 2024 · 2 comments
Closed

Switch Spectrogram to utilizing pre-signed URLS #19

BryonLewis opened this issue Jan 20, 2024 · 2 comments
Assignees
Labels
backend client Client side changes

Comments

@BryonLewis
Copy link
Collaborator

The current system is creating a local image (and for non-compressed) storing in minio and then converting it to base64 so it can be transfered to the front-end. This was just done initially to have something to display. It would make more sense to utilize pre-signed URLs.

Compressed View

It may make sense to make a compressed view that is also stored in MinIO. We may just have it updated when annotations are edited so it has some sort of caching system.

@BryonLewis BryonLewis added client Client side changes backend labels Jan 20, 2024
@BryonLewis BryonLewis self-assigned this Jan 24, 2024
@BryonLewis
Copy link
Collaborator Author

The system is using presigned URLs now that are stored in MinIO instead of directly generating the spectrogram every time.
This can be seen here: https://github.com/Kitware/batai/blob/main/client/src/api/api.ts#L111
Also here in the initalieViewer function for the geoJS layer it uses the URL directly to render the image:
https://github.com/Kitware/batai/blob/main/client/src/components/geoJS/geoJSUtils.ts#L117

@BryonLewis
Copy link
Collaborator Author

fixed in #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend client Client side changes
Projects
None yet
Development

No branches or pull requests

1 participant