Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GLTFImporter): fix GLTF Draco normals #3193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(GLTFImporter): fix GLTF Draco normals #3193

wants to merge 1 commit into from

Conversation

daker
Copy link
Collaborator

@daker daker commented Dec 15, 2024

Context

fix #3192

Results

Enregistrement.2024-12-15.222041.mp4

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker force-pushed the fix-gltf-draco-normals branch 2 times, most recently from 3c9e647 to bb52b95 Compare December 19, 2024 13:27
@daker
Copy link
Collaborator Author

daker commented Dec 19, 2024

@finetjul I have upgraded the draco lib to the latest version and i generate the normals if they are missing.

@daker daker requested a review from finetjul December 19, 2024 13:30
@daker daker force-pushed the fix-gltf-draco-normals branch 2 times, most recently from 0a95753 to d1a5a5a Compare December 19, 2024 14:03
finetjul
finetjul approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@floryst could it be considered as breaking change ?

@daker
Copy link
Collaborator Author

daker commented Dec 19, 2024

@finetjul the only breaking change is the switch to promise/async setDracoDecoder imposed by the library.

@daker daker force-pushed the fix-gltf-draco-normals branch from d1a5a5a to 269a137 Compare December 19, 2024 22:25
floryst
floryst approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good to keep this as a non-breaking change. I'm partly making this call due to draco3d not designating it as a breaking change (assuming they follow semantic versioning), as they introduce it in the 1.3.6->1.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryst floryst floryst approved these changes

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] GLTF Draco wrong normals
3 participants
@daker @finetjul @floryst