Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faction -> Ranked War Page: Add country info #570

Open
SeanTomlinson30 opened this issue Apr 6, 2024 · 3 comments · May be fixed by #574
Open

Faction -> Ranked War Page: Add country info #570

SeanTomlinson30 opened this issue Apr 6, 2024 · 3 comments · May be fixed by #574

Comments

@SeanTomlinson30
Copy link

Background: The ranked war page is an invaluable tool. It is used ubiquitously when engaged in faction wars.

Issue: When stalking targets across different countries. the tool only shows 'Travelling' or 'Abroad'

Request: It would be infinitely useful if it instead said the country to where they are travelling or the country they are currently in. At the moment if you hover over the 'travelling' or 'abroad' label a tooltip says the specific country. Either it should just say the country information by default, or an option should be togglable to have this info show in the ranked war table.

Rationale: A lot of time is wasted during war going down each and every target who is travelling and abroad to coordinate and plan attacks with fellow faction members. This change would be a help and a boon to all.
Swiftkilla123 added a commit to Swiftkilla123/yata that referenced this issue Apr 9, 2024
@Swiftkilla123
Update target.html
45d306e 
move the title to the cell text, also ensure we display something meaningful if we don't have the information on destination

resolves: Kivou-2000607#570
@Swiftkilla123 Swiftkilla123 linked a pull request Apr 9, 2024 that will close this issue
Open
@Swiftkilla123
Copy link
Contributor

Swiftkilla123 commented Apr 9, 2024 •
edited
Loading

@SeanTomlinson30 great idea. I propose we move the "Travelling to destination" to replace the generic "Travelling" that is currently there like so:
image

Swiftkilla123 added a commit to Swiftkilla123/yata that referenced this issue Apr 9, 2024
@Swiftkilla123
move last commit
c724b27 
moved to correct if statement, travelling is "blue"

resolves: Kivou-2000607#570
Swiftkilla123 added a commit to Swiftkilla123/yata that referenced this issue Apr 10, 2024
@Swiftkilla123
better display for travel status
f63fe86 
resolves: Kivou-2000607#570
Swiftkilla123 added a commit to Swiftkilla123/yata that referenced this issue Apr 10, 2024
@Swiftkilla123
correct return fallback
e4a674b 
resolves: Kivou-2000607#570
@SeanTomlinson30
Copy link
Author

exactly what I meant - this will be a great feature for warring

@Swiftkilla123
Copy link
Contributor

Hey Sean, we have worked on this and are looking to implement it, however the proposed solution is being discussed to ensure its what's best for the tool. Will keep you posted when this gets released. Great suggestion. Keep them coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update target.html Swiftkilla123/yata
2 participants
@SeanTomlinson30 @Swiftkilla123