Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Optmizations #50

Open
Kiyoshika opened this issue Jun 10, 2023 · 0 comments
Open

Future Optmizations #50

Kiyoshika opened this issue Jun 10, 2023 · 0 comments

Comments

@Kiyoshika
Copy link
Owner

When first writing this library I didn't want to prematurely optimize (and still don't care about it just yet) but wanted to store any future possible optimizations whenever we get to that point.

  • fetch_..._string() in json_internal
    • These functions reallocate and free different heap buffers many times (especially for large files). Will probably be worth it to use ONE heap buffer during parsing and just resize it if we end up getting a value that's larger than the current max
    • This also computes the length of the parse string each time (which sometimes can be very long). Will be better to precompute it and pass it as an arg or store it in parse_info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant