-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with using KoGrid in Single Page Application #209
Comments
Frankly, I am not sure that it's good solution, so posting possible fix for this behavior: in the grid.js at buildColumns function, now I have: |
Hi ArmHorse, I have this issue as well. I tried your suggested solution, but columnDefs[0] was sometimes undefined so i added an extra check as follows:
Otherwise, the fix seems to work. |
Submitted a pull request - #213 |
Here is a custom binding to solve the issue and avoid the koGrid source code changing (I really don't like 3rd party source code changing in my project, even if it seems to be abandoned like this one) ko.bindingHandlers["koGridFixed"] = {
init: function (element, valueAccessor, allBindingsAccessor, data, context) {
var gridOptions = ko.utils.unwrapObservable(valueAccessor());
if (gridOptions && gridOptions.columnDefs) {
var columnDefsArr = ko.utils.unwrapObservable(gridOptions.columnDefs);
if (columnDefsArr && columnDefsArr.length > 0 && columnDefsArr[0].field === '\u2714')
columnDefsArr.splice(0, 1);
}
return ko.bindingHandlers["koGrid"].init(element, valueAccessor, allBindingsAccessor, data, context);
}
}; Replace all koGrid binding in views with koGridFixed. I've described these bug and fix in my blog - koGrid: Bug – Checkboxes column duplication. |
I got strange behavior with using KoGrid in single page app - it's adding one more row selection checkbox each time, when I am switching between tabs in my application. To explain better, I have reproduced it here: http://jsfiddle.net/ArmHorse/vXjK7/. Please, advice.
The text was updated successfully, but these errors were encountered: