From fd669bdaefcf31556227bbbe4d695beb6cad4b4b Mon Sep 17 00:00:00 2001 From: Hugo Alliaume Date: Fri, 29 Nov 2024 13:53:19 +0100 Subject: [PATCH 1/2] Ensure Symfony 7.1 and 7.2 are supported, close #7 --- .github/workflows/ci.yaml | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c736b29..874c109 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -61,12 +61,28 @@ jobs: - PHP_VERSION: '8.4' SYMFONY_VERSION: '7.0' + # Latest 7.1 stable releases + - PHP_VERSION: '8.2' + SYMFONY_VERSION: '7.1' + - PHP_VERSION: '8.3' + SYMFONY_VERSION: '7.1' + - PHP_VERSION: '8.4' + SYMFONY_VERSION: '7.1' + + # Latest 7.2 stable releases + - PHP_VERSION: '8.2' + SYMFONY_VERSION: '7.2' + - PHP_VERSION: '8.3' + SYMFONY_VERSION: '7.2' + - PHP_VERSION: '8.4' + SYMFONY_VERSION: '7.2' + # Highest supported PHP version with the latest Symfony version, on Windows and macOS - PHP_VERSION: '8.4' - SYMFONY_VERSION: '7.0' + SYMFONY_VERSION: '7.2' OS: windows-latest - PHP_VERSION: '8.4' - SYMFONY_VERSION: '7.0' + SYMFONY_VERSION: '7.2' OS: macos-14 # Latest 7.x development releases @@ -107,7 +123,7 @@ jobs: - name: Run PHPUnit run: symfony php vendor/bin/phpunit - + e2e: name: E2E runs-on: ubuntu-latest @@ -128,7 +144,7 @@ jobs: git config --global user.email "hugo@alliau.me" git config --global user.name "Hugo Alliaume" symfony new my_app --webapp - + - name: Install kocal/biome-js-bundle run: | symfony composer config minimum-stability dev From 55195c880e28ccb199be329e25ab5db21f3b7378 Mon Sep 17 00:00:00 2001 From: Hugo Alliaume Date: Fri, 29 Nov 2024 14:15:57 +0100 Subject: [PATCH 2/2] fix(ci): use unsafe write --- .github/workflows/ci.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 874c109..e411fbb 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -162,6 +162,13 @@ jobs: "public/bundles/*", "vendor/*" ] + }, + "linter": { + "rules" :{ + "suspicious": { + "noAssignInExpressions": "off" + } + } } } EOF @@ -173,7 +180,7 @@ jobs: working-directory: my_app - name: Run Biome Check, and apply fixes - run: symfony console biomejs:check . --write + run: symfony console biomejs:check . --write --unsafe working-directory: my_app - name: Run Biome CI, which should now pass