Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<baseFileName> for TV shows not replaced in Renamer #1813

Open
2 tasks
ThePapaw opened this issue Nov 3, 2024 · 2 comments
Open
2 tasks

<baseFileName> for TV shows not replaced in Renamer #1813

ThePapaw opened this issue Nov 3, 2024 · 2 comments
Labels
bug component: TV shows TV shows, series, episodes
Milestone

Comments

@ThePapaw
Copy link

ThePapaw commented Nov 3, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings > TV Shows'
  2. Click on 'edit field, such as poster to -poster.jpg'

Expected behavior
download file will be renamed with -poster.

Screenshots
Screenshots added with setting and results for poster and fanart
01
02

MediaElch Version:

  • 2.12.0 (stable)

Operating System:

  • Windows

Additional context
Just not adding the basefilename, not sure how many field are affected.

@ThePapaw
Copy link
Author

ThePapaw commented Nov 3, 2024

Appear broken on all fields after further testing

@bugwelle bugwelle changed the title File Renaming Not Correct <baseFileName> for TV shows not replaced in Renamer Nov 4, 2024
@bugwelle bugwelle added bug component: TV shows TV shows, series, episodes labels Nov 4, 2024
@bugwelle
Copy link
Collaborator

bugwelle commented Nov 4, 2024

@ThePapaw Thanks for reporting this issue.

Please note that, due to limited time, I may not get to work on this in the foreseeable future. See #1710 for details.

Regards,
Andre


Notes:

bool KodiXml::saveTvShow(TvShow* show)
…
QString saveFileName = dataFile.saveFileName("");

=> we need to get the NFO's filename and pass it to saveFileName().

@bugwelle bugwelle added this to the v2.12.2 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: TV shows TV shows, series, episodes
Projects
None yet
Development

No branches or pull requests

2 participants