Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko/dialogs open() does not show title and text with default buttons; prompt not at all #3278

Open
mjross opened this issue Oct 15, 2017 · 5 comments
Assignees
Milestone

Comments

@mjross
Copy link

mjross commented Oct 15, 2017

Summary

In the require( "ko/dialogs" ).open() method, the title and text options are apparently not displayable if the default buttons are used.

The prompt option is apparently not displayable at all.

Steps to Reproduce

The example code and attachments below illustrate the issue:

var d = require( "ko/dialogs" );
d.open( "message", { title: "title 1\ntitle 2", text: "text 1\ntext 2", prompt: "prompt 1\nprompt 2" } );
d.open( "message", { title: "title 1\ntitle 2", text: "text 1\ntext 2", prompt: "prompt 1\nprompt 2", buttons: ["Yes", "No"] } );

Platform Information

Komodo IDE 11.0.0 build 90668 on Windows 10 Pro

Attachments

open dialog 1
open dialog 2

@Naatan Naatan self-assigned this Oct 16, 2017
@Naatan Naatan added this to the Perpetual milestone Oct 16, 2017
@Naatan Naatan assigned th3coop and unassigned Naatan Oct 16, 2017
@Naatan
Copy link
Member

Naatan commented Oct 16, 2017

Thanks @mjross. Note I would highly recommend using ko/modal over this SDK, it is far more flexible and does not depend on legacy code.

@mjross
Copy link
Author

mjross commented Oct 16, 2017

Interesting. I had assumed that ko/dialogs was at the same level as all the others listed in the documentation, in terms of how up-to-date the code is.

@Naatan
Copy link
Member

Naatan commented Oct 16, 2017

The ko/dialogs code is a wrapper module for old legacy code. I created ko/modal some time later to supersede much of the functionality of ko/dialogs.

@mjross
Copy link
Author

mjross commented Oct 16, 2017

Good to know. Shall I continue to report on misbehavior detected in the ko/dialogs methods? (I'm currently seeing oddities in filepicker() and prompt().)

@Naatan
Copy link
Member

Naatan commented Oct 16, 2017

Oh yes, please do :) We haven't deprecated it yet. I'm just giving you a heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants