Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): fix tls_passthrough in expression flavor #11538

Merged
merged 13 commits into from
Sep 18, 2023
Merged

fix(router): fix tls_passthrough in expression flavor #11538

merged 13 commits into from
Sep 18, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 11, 2023 •
edited
Loading

Summary

KAG-2561
See: Kong/kubernetes-ingress-controller#4574 (comment)

Blocked by #11550

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@randmonkey randmonkey mentioned this pull request Sep 11, 2023
Merged
1 task
@chronolaw chronolaw marked this pull request as draft September 11, 2023 11:37
@rainest rainest mentioned this pull request Sep 11, 2023
Closed
3 tasks
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 12, 2023
@chronolaw chronolaw force-pushed the fix/expression_tls_passthough branch from 7a28b3c to 4ca1027 Compare September 12, 2023 07:50
@chronolaw chronolaw force-pushed the fix/expression_tls_passthough branch from 4ca1027 to 600b5d1 Compare September 12, 2023 08:33
@chronolaw chronolaw changed the title fix(router): fix tls_passthough in expression flavor fix(router): fix tls_passthrough in expression flavor Sep 12, 2023
@chronolaw chronolaw force-pushed the fix/expression_tls_passthough branch from 5d4bdd1 to 26af897 Compare September 12, 2023 09:03
@chronolaw chronolaw marked this pull request as ready for review September 13, 2023 01:33
@chronolaw chronolaw requested a review from dndx September 13, 2023 03:55
@windmgc windmgc merged commit 66795cd into master Sep 18, 2023
25 checks passed
@windmgc windmgc deleted the fix/expression_tls_passthough branch September 18, 2023 02:41
@team-gateway-bot team-gateway-bot mentioned this pull request Sep 18, 2023
Merged
team-gateway-bot pushed a commit that referenced this pull request Sep 18, 2023
@chronolaw @github-actions
fix(router): fix tls_passthrough in expression flavor (#11538)
617f97a 
Fix an issue that protocol `tls_passthrough` can not work with expressions flavor

KAG-2561
See: Kong/kubernetes-ingress-controller#4574 (comment)

(cherry picked from commit 66795cd)
windmgc pushed a commit that referenced this pull request Sep 19, 2023
@chronolaw @windmgc
fix(router): fix tls_passthrough in expression flavor (#11538)
d8cf3aa 
Fix an issue that protocol `tls_passthrough` can not work with expressions flavor

KAG-2561
See: Kong/kubernetes-ingress-controller#4574 (comment)

(cherry picked from commit 66795cd)
@mflendrich mflendrich mentioned this pull request Sep 20, 2023
Closed
4 tasks
@kikito kikito mentioned this pull request Oct 3, 2023
Merged
@kikito kikito mentioned this pull request Jan 24, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randmonkey randmonkey randmonkey approved these changes

@dndx dndx Awaiting requested review from dndx

Assignees

@chronolaw chronolaw

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @randmonkey @windmgc