Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Gateway API support for query string matching on HTTP routes #2778

Closed
1 task
mflendrich opened this issue Aug 4, 2022 · 4 comments
Closed
1 task
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API area/spike kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API nice-to-have
Milestone

Comments

@mflendrich
Copy link
Contributor

mflendrich commented Aug 4, 2022

Problem Statement

Query string matching is an extended feature of Gateway API, but if we can support it we would like to.

Acceptance Criteria

  • spike the options and effort to enable query string route matching in KIC. (If the implementation is sufficiently complex, then the result of this issue should be a KEP or some other kind of design doc)
@shaneutt shaneutt changed the title Gateway API support for query string matching on HTTP routes Spike: Gateway API support for query string matching on HTTP routes Aug 4, 2022
@shaneutt shaneutt added area/spike area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API labels Aug 4, 2022
@shaneutt shaneutt added this to the Gateway API - Milestone 4 milestone Aug 4, 2022
@jrsmroz
Copy link
Contributor

jrsmroz commented Oct 13, 2022

  • Kong does not support routing based on query params natively.
  • Path regex can't be used, as only paths are matched, not query string.
  • Router expressions does not expose query string
  • We don't have a plugin that can be used. We would need to create one.

Related kong issue: Kong/kong#4919

@jrsmroz
Copy link
Contributor

jrsmroz commented Oct 19, 2022

QueryParamMatchType does not mark the QueryParams field with Support: Extended It's a doc issue.

@randmonkey
Copy link
Contributor

Now Kong gateway has supported matching HTTP query parameters in expression router: Kong/kong#11348 We can move on to this (note that we only support query param matching in Kong 3.5 and later).

@mflendrich mflendrich modified the milestones: KIC v2.12.0, KIC v3.0.0 Aug 23, 2023
@mlavacca mlavacca added the kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API label Aug 24, 2023
@mflendrich
Copy link
Contributor Author

This feature has been implemented in Kong (Kong/kong#11348), will be backported into 3.4.x (Kong/kong#11469) and the Gateway API conformance part will be covered by #3679.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API area/spike kind/conformance Conformance to upstream Kubernetes SIG Networking Gateway API nice-to-have
Projects
None yet
Development

No branches or pull requests

5 participants