Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import/export account for Cardano #3924

Closed
4 tasks done
nampc1 opened this issue Dec 16, 2024 · 3 comments · Fixed by #3929
Closed
4 tasks done

Update import/export account for Cardano #3924

nampc1 opened this issue Dec 16, 2024 · 3 comments · Fixed by #3929
Assignees

Comments

@nampc1
Copy link

nampc1 commented Dec 16, 2024

  • Allow import/export for 15-word seed phrase
  • Warn users about wallet compatibility upon creating unified account -> No need
  • Support import/export JSON file for Cardano on Unified account
  • Fix bug importing watch-only account
    image
@Sokol142196
Copy link

Sokol142196 commented Dec 24, 2024

  • Show popup Incompatible seed phrase when import Cardano account (15 words)
    • Actual:
      • Show popup Incompatible seed phrase
      • Create Unified account
        Image
    • Expect: Do not show popup, create Cardano solo account

@bluezdot
Copy link

Show popup Incompatible seed phrase when import Cardano account (15 words)

Polkadot.js (Substrate) and Metamask (Ethereum) also supported for 15-words seed. The accounts created from those wallets are compatible with the unified account created from SubWallet => We can create unified account from 15-words seed.

@haiyenvu23
Copy link

Version test : https://drive.google.com/file/d/1NgxGl4k5h07zsh-JF9E6DqZLFt66MOKL/view?usp=sharing
Validation passed in case :

  • Install/Update version

  • Allow import/export for 15-word seed phrase
    Image

  • Re-check create new account and import by seed phrase on other wallets

  • Support import/export JSON file for Cardano on Unified account
    Image

  • Re-check export on account detail

  • Re-check export all mode

  • Re-check export with popup back up seedphrase

  • Check when import watch only Cardano account
    Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants