Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support getting a canonical file Path #223

Open
jeffdgr8 opened this issue Sep 17, 2023 · 3 comments · Fixed by #228 · May be fixed by #286
Open

Support getting a canonical file Path #223

jeffdgr8 opened this issue Sep 17, 2023 · 3 comments · Fixed by #228 · May be fixed by #286
Assignees
@fzhinkin
Labels
enhancement fs

Comments

@jeffdgr8
Copy link
Contributor

Getting a file's canonical path is one of the few file APIs my library tests require that kotlinx-io doesn't currently support.

Similar API references:
@fzhinkin fzhinkin mentioned this issue Oct 12, 2023
Merged
@fzhinkin fzhinkin linked a pull request Oct 12, 2023 that will close this issue
Support path resolution #228
Merged
@fzhinkin fzhinkin self-assigned this Oct 12, 2023
@fzhinkin fzhinkin added the fs label Oct 12, 2023
@jeffdgr8
Copy link
Contributor Author

jeffdgr8 commented Feb 2, 2024

@fzhinkin I just checked out this new FileSystem.resolve(Path) API in 0.3.1. The issue I ran into is the fact that it throws FileNotFoundException when the file doesn't exist. Would it be possible to have a way to get a canonical path even for non-existent files?

@fzhinkin fzhinkin reopened this Feb 5, 2024
@fzhinkin
Copy link
Collaborator

fzhinkin commented Feb 5, 2024

Yes, need to support canonicalization without link resolution.

fzhinkin added a commit that referenced this issue Mar 18, 2024
@fzhinkin
Support path normalization
c59dfb1 
Closes #223
@fzhinkin fzhinkin linked a pull request Mar 19, 2024 that will close this issue
Draft
@fzhinkin fzhinkin linked a pull request Mar 19, 2024 that will close this issue
Implement path normalization #286
Draft
@mipastgt
Copy link

I have to say that this missing feature makes the whole library currently unusable for me. I hope that this can be fixed soon.

@fzhinkin fzhinkin mentioned this issue Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzhinkin fzhinkin

Labels
enhancement fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support path resolution Kotlin/kotlinx-io
Implement path normalization Kotlin/kotlinx-io
3 participants
@jeffdgr8 @fzhinkin @mipastgt