Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude companion object from report if it contains only constants #583

Closed
shanshin opened this issue Mar 26, 2024 · 1 comment · Fixed by #603
Closed

Exclude companion object from report if it contains only constants #583

shanshin opened this issue Mar 26, 2024 · 1 comment · Fixed by #603
Assignees
@shanshin
Labels
Bug Bug issue type

Comments

@shanshin
Copy link
Collaborator

Describe the bug
Same as for regular object, companion object with only should be excluded from report

Expected behavior
MyInterface should be excluded from report

Reproducer

interface MyInterface {
    companion object {
        const val constant = "foo"
    }
}

Reports
Screenshot 2024-03-26 at 20 25 06

Environment

  • Kover Gradle Plugin version: 0.7.6, 0.8.0-Beta
@shanshin shanshin added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels Mar 26, 2024
@shanshin shanshin self-assigned this Mar 26, 2024
@shanshin shanshin mentioned this issue Mar 26, 2024
Closed
@shanshin shanshin added S: confirmed Status: bug is reproduced or present and removed S: untriaged Status: issue reported but unprocessed labels Mar 28, 2024
@shanshin shanshin added S: in progress Status: implementing or design in process and removed S: confirmed Status: bug is reproduced or present labels May 1, 2024
shanshin added a commit that referenced this issue May 1, 2024
@shanshin
Excluded from report companion objects with only constants
c236cff 
Fixes #583
@shanshin shanshin removed the S: in progress Status: implementing or design in process label May 1, 2024
@shanshin shanshin mentioned this issue May 1, 2024
Merged
shanshin added a commit that referenced this issue May 1, 2024
@shanshin
Excluded from report companion objects with only constants
ee3dcd5 
Fixes #583
shanshin added a commit that referenced this issue May 3, 2024
@shanshin
Excluded from report companion objects with only constants
3594ebd 
Fixes #583
PR #603
@shanshin shanshin reopened this May 3, 2024
@shanshin shanshin added the S: ready for release Status: merged in the main branch label May 3, 2024
@shanshin
Copy link
Collaborator Author

Fixed in 0.8.0

@shanshin shanshin removed the S: ready for release Status: merged in the main branch label May 15, 2024
@shanshin shanshin mentioned this issue May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Bug Bug issue type
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Excluded from report companion objects with only constants Kotlin/kotlinx-kover
1 participant
@shanshin