Fixed warning for empty Kotlin plugin configuration #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a configuration is specified in the execution for the `compile` target, but the `sourceDirs` child element is missing, an error occurred. A check has been added to fix the error. Fixes #701
sandwwraith
approved these changes
Nov 8, 2024
| (execution.configuration as Xpp3Dom).getChild("sourceDirs").children.map { toAbsoluteFile(it.value) } | ||
| val config = execution.configuration as Xpp3Dom | ||
| val sourceDirs = config.getChild("sourceDirs") ?: return@flatMap emptyList() | ||
| sourceDirs.children.map { toAbsoluteFile(it.value) } |
There was a problem hiding this comment.
If there are <sourceDirs><sourceDirs/>, but no children are specified, will children be a null or an emptyList?
There was a problem hiding this comment.
Empty list, it's not mentioned in the docs, but implementation is
public Xpp3Dom[] getChildren()
{
if ( null == childList || childList.isEmpty() )
{
return EMPTY_DOM_ARRAY;
}
else
{
return (Xpp3Dom[]) childList.toArray( new Xpp3Dom[childList.size()] );
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a configuration is specified in the execution for the
compiletarget, but thesourceDirschild element is missing, an error occurred. A check has been added to fix the error.Fixes #701