Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@soudah] Fluid non newtonian const. laws with qsvms element #675

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jginternational
Copy link
Member

Added 2 constitutive laws forn non newtonian fluids

Changed the element from vms to qsvms

@jginternational
Copy link
Member Author

ping @KratosMultiphysics/fluid-dynamics

@rubenzorrilla
Copy link
Member

We should decide if the reference monolithic element is now the QSVMS (this goes in) or if we keep the VMS one (this is closed).

If we decide that the QSVMS becomes the reference one, I wouldn't add the non-newtonian laws until we have implemented their 2D version.

@rubenzorrilla
Copy link
Member

Guys, this PR deals with the addition of the non-newtonian constitutive laws and the setting of the QSVMS as reference element in the FluidDynamicsApplication.

I can see some changes related with the Wall Shear Stress (WSS) developments, which are out of the scope of the PR and the FluidDynamicsApplication.

Having said this I'd:

  • remove the WSS-related changes from this PR
  • add the WSS (and other Biomedical magnitudes) to a new GUI derived from the fluid one. Note that these magnitudes make not so much sense when solving non-biomedical problems.

Copy link
Member

@rubenzorrilla rubenzorrilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(blocking to avoid accidental merge)

@jginternational
Copy link
Member Author

Thanks @rubenzorrilla

Let @soudah play in this branch. I won't allow the merging until a Bio** Application (derived from fluid dynamics) is created for these changes.

@jginternational jginternational changed the title Fluid non newtonian const. laws with qsvms element [@soudah] Fluid non newtonian const. laws with qsvms element May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants