Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Auxiliar_process_list or auxilliary_process_list #13123

Open
WPK4FEM opened this issue Feb 13, 2025 · 0 comments · May be fixed by #13124
Open

[GeoMechanicsApplication] Auxiliar_process_list or auxilliary_process_list #13123

WPK4FEM opened this issue Feb 13, 2025 · 0 comments · May be fixed by #13124
Assignees

Comments

@WPK4FEM
Copy link
Contributor

WPK4FEM commented Feb 13, 2025

Magically both seem to be accepted reading the ProjectParameters.json files.
It is not clear why. If possible stick to the spelling with y.

After some further investigation:

  • 3 different spellings occur: auxiliar_process_list, auxiliary_process_list, auxilliary_process_list
  • only c_phi and K0 procedure tests use this list, they mostly use auxilliary_process_list ( only test settlement workflow uses auxiliar ) and run correctly
  • all other occurences in .json files are empty lists. When removing the empty list definition, the tests still pass
  • when I change constraints_process_list to aapjes_process_list and loads_process_list to nootjes_process_list the test still passes. However, output_processes is apparently checked. Changing output_processes to something_else leads to no output generated.
  • json_process_info_parser.cpp and test_process_info_parser.cpp use auxiliar_process_list

Proposed actions:

1: remove all empty occurances of auxiliar_process_list
2: use correct spelling in the non-empty auxilliary_process_list

Acceptance criteria:

When: No K0 or C/Phi reduction process is present,
Then: No Auxilliary_process_list is in the ProjectParameters.json file

When: A K0 or C/Phi is present in ProjectParameters.json in a python or c++ workflow
Then: It is in a correctly spelled auxilliary_process_list

@WPK4FEM WPK4FEM self-assigned this Feb 13, 2025
@WPK4FEM WPK4FEM converted this from a draft issue Feb 13, 2025
@WPK4FEM WPK4FEM linked a pull request Feb 13, 2025 that will close this issue
@WPK4FEM WPK4FEM moved this from 📑 Product Backlog to 📋 Sprint Backlog in Kratos Product Backlog Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant