You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Magically both seem to be accepted reading the ProjectParameters.json files.
It is not clear why. If possible stick to the spelling with y.
After some further investigation:
3 different spellings occur: auxiliar_process_list, auxiliary_process_list, auxilliary_process_list
only c_phi and K0 procedure tests use this list, they mostly use auxilliary_process_list ( only test settlement workflow uses auxiliar ) and run correctly
all other occurences in .json files are empty lists. When removing the empty list definition, the tests still pass
when I change constraints_process_list to aapjes_process_list and loads_process_list to nootjes_process_list the test still passes. However, output_processes is apparently checked. Changing output_processes to something_else leads to no output generated.
json_process_info_parser.cpp and test_process_info_parser.cpp use auxiliar_process_list
Proposed actions:
1: remove all empty occurances of auxiliar_process_list
2: use correct spelling in the non-empty auxilliary_process_list
Acceptance criteria:
When: No K0 or C/Phi reduction process is present, Then: No Auxilliary_process_list is in the ProjectParameters.json file
When: A K0 or C/Phi is present in ProjectParameters.json in a python or c++ workflow Then: It is in a correctly spelled auxilliary_process_list
The text was updated successfully, but these errors were encountered:
Magically both seem to be accepted reading the ProjectParameters.json files.
It is not clear why. If possible stick to the spelling with y.
After some further investigation:
Proposed actions:
1: remove all empty occurances of auxiliar_process_list
2: use correct spelling in the non-empty auxilliary_process_list
Acceptance criteria:
When: No K0 or C/Phi reduction process is present,
Then: No Auxilliary_process_list is in the ProjectParameters.json file
When: A K0 or C/Phi is present in ProjectParameters.json in a python or c++ workflow
Then: It is in a correctly spelled auxilliary_process_list
The text was updated successfully, but these errors were encountered: