Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo/check number of tables phreatic multi line #12689

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WPK4FEM
Copy link
Contributor

@WPK4FEM WPK4FEM commented Sep 20, 2024

📝 Description
To make sure that the number of tables matches the number of points of the multlinear phreatic line input a check has been added.

🆕 Changelog

  • Check added
  • Unit test added
  • Some scrambled and redundant project parameters syntax corrected.

@WPK4FEM WPK4FEM self-assigned this Sep 20, 2024
Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and well tested and scoped fix! I have some questions left, mainly about the 'constant' version of the multiline process and the defaults.

Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice sanity check, thanks for adding it! After our discussions, this is ready to go from my perspective

@rfaasse
Copy link
Contributor

rfaasse commented Oct 25, 2024

FYI We need to bring it up to date with master before we can merge (due to the failing windows pipeline being fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants