-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geo/check number of tables phreatic multi line #12689
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch and well tested and scoped fix! I have some questions left, mainly about the 'constant' version of the multiline process and the defaults.
...echanicsApplication/custom_processes/apply_constant_phreatic_multi_line_pressure_process.cpp
Show resolved
Hide resolved
...nicsApplication/tests/cpp_tests/test_apply_constant_phreatic_multi_line_pressure_process.cpp
Outdated
Show resolved
Hide resolved
...echanicsApplication/custom_processes/apply_constant_phreatic_multi_line_pressure_process.cpp
Show resolved
Hide resolved
...chanicsApplication/tests/cpp_tests/test_apply_phreatic_multi_line_pressure_table_process.cpp
Outdated
Show resolved
Hide resolved
...nicsApplication/tests/cpp_tests/test_apply_constant_phreatic_multi_line_pressure_process.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice sanity check, thanks for adding it! After our discussions, this is ready to go from my perspective
FYI We need to bring it up to date with master before we can merge (due to the failing windows pipeline being fixed) |
📝 Description
To make sure that the number of tables matches the number of points of the multlinear phreatic line input a check has been added.
🆕 Changelog