[Core][Tests] Fixing numpy copy=false #12891
Merged
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
previously approved these changes
Nov 29, 2024
|
hdf5 and Swimming dem still giving problems, investigating. @sunethwarna Do you make use of Nevermind, seems its a problem with virtually any other lib |
loumalouomega
previously approved these changes
Nov 29, 2024
|
@roigcarlo no we don't use pandas there. But here are some tests which use h5py. |
|
Yep, sorry for the noise, i will just rollback numpy to 1.26, 🤞 |
loumalouomega
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
See https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword for more info.
@AlejandroCornejo This should fix the PR.
@KratosMultiphysics/all Linux CI build will likely fail until this is merged. Sorry for the problems but were not aware that upstream numpy was updated.