Skip to content
This repository has been archived by the owner on Apr 23, 2023. It is now read-only.

Chaptered usage updates #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Quietus
Copy link

@Quietus Quietus commented Mar 25, 2022

Unsure if you want all these changes or if you want to handle these differently. At present, in chaptered mode there's an error when adding the cover art (#208), because it tries to do so to the base filename instead of the chapter files. Options are:

  1. Add the cover art to every chapter.
  2. Don't add the cover art to any file and leave the cover art in the folder instead.

I chose option 2.

The additional file cleanup should probably not use mv -v (verbose move)

The flattening at lines 540-543 mirrors the one done in #207 which applied to single-file mode only.

Fixed an issue encountered if ffprobe returned 2 items.
Improved cleanup if audiblecli in use.
…single mode, to avoid issues with nested chapter structures in books.
@Maloupi
Copy link

Maloupi commented Mar 25, 2022

Hi,
Thank you :-)
I understand the move of jpg file to complete dir but why moving voucher and chapters ?

@Quietus
Copy link
Author

Quietus commented Mar 25, 2022

They're all part of the files from using audible-cli and relate to that book. If I'm using the -C/--complete_dir flag, I want all the files related to that book to be moved to the complete_dir (for archival).

With respect to the issue you raised, all I've changed is not trying to add the cover art to the output file (these are the changes at line 291 and 972). The jpg is already copied to the output folder in lines 795-809

@Maloupi
Copy link

Maloupi commented Mar 25, 2022

I understand :-) Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants