Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: monitoring module #58

Closed
wants to merge 4 commits into from

Conversation

ffforest
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@ffforest ffforest requested review from elliotxx and adohe as code owners March 18, 2024 09:05
Copy link

github-actions bot commented Mar 18, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ffforest ffforest force-pushed the feat-monitoring-refactor branch from cb739e0 to f97e4d3 Compare March 18, 2024 09:11
@ffforest
Copy link
Contributor Author

ffforest commented Mar 18, 2024

Relying on a module-related feature to properly process a module.GeneratorResponse without an actual v1.resource, in this case, a v1.resource with (most likely only) a Patcher field to patch the workload annotations.
@SparkYuan

@ffforest ffforest changed the title [WIP] refactor: add monitoring generator [WIP] refactor: monitoring module Mar 20, 2024
@ffforest ffforest force-pushed the feat-monitoring-refactor branch from f09c3c7 to 4c445c8 Compare March 20, 2024 09:08
@ffforest ffforest changed the title [WIP] refactor: monitoring module refactor: monitoring module Mar 21, 2024
@ffforest ffforest requested review from SparkYuan and liu-hm19 and removed request for elliotxx March 21, 2024 02:52
@ffforest ffforest self-assigned this Mar 21, 2024
@ffforest ffforest added the enhancement New feature or request label Mar 21, 2024
@ffforest ffforest force-pushed the feat-monitoring-refactor branch from 506b18f to 3f2f9ac Compare March 21, 2024 02:54
@ffforest ffforest force-pushed the feat-monitoring-refactor branch from 3f2f9ac to 71efd76 Compare March 21, 2024 02:59
@ffforest
Copy link
Contributor Author

Tracking this in #61

@ffforest ffforest closed this Mar 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant