From 12ca37b9a16cb5656f5327c88af0d1730a6c1239 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 5 Sep 2023 10:52:49 -0300 Subject: [PATCH 1/2] chore(deps): bump actions/checkout from 3 to 4 (#953) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/codeql.yml | 2 +- .github/workflows/jest.yml | 2 +- .github/workflows/lighthouse.yml | 2 +- .github/workflows/publish-sdk.yml | 2 +- .github/workflows/sentry.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index a98e37b140..cc66f39437 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -25,7 +25,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Initialize CodeQL uses: github/codeql-action/init@v2 diff --git a/.github/workflows/jest.yml b/.github/workflows/jest.yml index 9cb5ac80b3..a5bce51478 100644 --- a/.github/workflows/jest.yml +++ b/.github/workflows/jest.yml @@ -12,7 +12,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 7937ce222f..6f1283687d 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -17,7 +17,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b # pin@v2 + uses: actions/checkout@v4 # pin@v2 - name: Run lighthouse run: | diff --git a/.github/workflows/publish-sdk.yml b/.github/workflows/publish-sdk.yml index 259bbb8d8c..4feff5d138 100644 --- a/.github/workflows/publish-sdk.yml +++ b/.github/workflows/publish-sdk.yml @@ -14,7 +14,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 diff --git a/.github/workflows/sentry.yml b/.github/workflows/sentry.yml index 87a2f06cba..f4eda6a753 100644 --- a/.github/workflows/sentry.yml +++ b/.github/workflows/sentry.yml @@ -11,7 +11,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: fetch-depth: 0 From 1cac2200a23ac7d696618c8be6a9eb442404c7e2 Mon Sep 17 00:00:00 2001 From: Adam Clarke Date: Tue, 5 Sep 2023 21:29:25 +0100 Subject: [PATCH 2/2] fix(app): incorrect pnl percent (#955) --- packages/app/src/utils/futures.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app/src/utils/futures.ts b/packages/app/src/utils/futures.ts index 57b0e43b90..381f951521 100644 --- a/packages/app/src/utils/futures.ts +++ b/packages/app/src/utils/futures.ts @@ -85,7 +85,7 @@ export const updatePositionUpnl = ( .sub(offChainPrice) .mul(position.side === PositionSide.LONG ? -1 : 1) ) - const pnlPct = pnl.div(position.initialMargin.add(thisPositionHistory.netTransfers)) + const pnlPct = pnl.div(thisPositionHistory.initialMargin.add(thisPositionHistory.netTransfers)) const accruedFunding = position.accruedFunding.add(thisPositionHistory.netFunding) return {