Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user can delete certificates #441

Closed
wants to merge 9 commits into from

Conversation

pavel-pasechnik
Copy link
Contributor

Bottom line:

  • Implemented authorization via Pundit to remove certificates.
  • Added support for roles with certificate:destroy activity.
  • Tests confirming correct work of changes are written.

app/controllers/certificates_controller.rb Dismissed Show dismissed Hide dismissed
@pavel-pasechnik pavel-pasechnik self-assigned this Dec 19, 2024
@pavel-pasechnik pavel-pasechnik added this to the Certificates milestone Dec 19, 2024
@@ -237,6 +242,23 @@ uk:
no_special_notes: 'поки що нотаток немає'
completed_questionnaires: 'Заповнені опитувальники'
study_applications: 'Заяви на навчання'
registration_time: 'Дата реєстрації'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavel-pasechnik please extract the changes not directly required in the task to a separate PR. It complicates the code review.

@pavel-pasechnik pavel-pasechnik deleted the Deleting-a-certificate-by-a-user branch January 29, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants