Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not interrupt PR builds when a step fails. #1

Open
schmitzhermes opened this issue Apr 7, 2017 · 0 comments
Open

Do not interrupt PR builds when a step fails. #1

schmitzhermes opened this issue Apr 7, 2017 · 0 comments

Comments

@schmitzhermes
Copy link
Member

Instead of interrupting a PR build, when one step fails, we should rather catch the error, report the failure to Github (maybe even in a more detailed manner: build, test, integration-test, docker-build) and go on with the build. By doing that we can assure that every step is executed and you can see e.g. your sonar issues or your code coverage even if your tests aren't passing (maybe because you do TDD and want to provide a test case to someone else or or or)
schmitzhermes added a commit that referenced this issue Oct 18, 2017
@schmitzhermes
Also match squashed commits with regex
9bad5b2 
This may be a dangerous change since there is no graceful handling of having a `#1` in your commit message without having Github insert it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schmitzhermes