Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched trace regions and wavelength regions lead to incorrect wavelengths #76

Open
gmbrandt opened this issue Jun 1, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@gmbrandt
Copy link
Collaborator

gmbrandt commented Jun 1, 2021

There was a bug where slight ~1 pixel noise in the trace centers led to extracted wavelengths being 10/11 's what they should be. We fixed this in PR #74 . But this was a temporary fix that basically takes the center pixel's wavelength along each column. If we ever go to a fully 2d wavelength solution (and non vertical extractions) we will need to apply a more robust fix (e.g., always using the same super lampflats for both the wavelength solution and extractions).

@gmbrandt gmbrandt added the enhancement New feature or request label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant