Fix/celery acks late #368
Merged
Fix/celery acks late #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 10, 2023 15:00
rabbitmq.lco.gtn was not resolving, presumably due to coreDNS upgrade
Make sure that tasks aren't acked until they're finished, rather than picked up so that they can be re-scheduled if a pod goes down.
Roll this change into the 1.11.0 release.
cmccully
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ack tasks late so that they may be re-queued in the event of a worker shutdown a la kubernetes
I've actually been running this for quite some time and we're missing a lot fewer frames. We should probably do this for all BANZAI deployments.