Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for SBML to 1, (keep existing compat) #792

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the SBML package from ~1.3, ~1.4 to ~1.3, ~1.4, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.59% ⚠️

Comparison is base (1f79432) 91.98% compared to head (e6e60a4) 91.39%.
Report is 2 commits behind head on develop.

❗ Current head e6e60a4 differs from pull request most recent head a264175. Consider uploading reports for the commit a264175 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #792      +/-   ##
===========================================
- Coverage    91.98%   91.39%   -0.59%     
===========================================
  Files           86       86              
  Lines         2257     2209      -48     
===========================================
- Hits          2076     2019      -57     
- Misses         181      190       +9     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Project.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you compathelper!

@exaexa exaexa merged commit 42e3528 into develop Sep 11, 2023
1 check passed
@exaexa exaexa deleted the compathelper/new_version/2023-08-31-01-15-33-689-01131048743 branch September 11, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant