Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable regex filtering #1

Closed
LCVcode opened this issue Mar 7, 2024 · 1 comment · Fixed by #47
Closed

Enable regex filtering #1

LCVcode opened this issue Mar 7, 2024 · 1 comment · Fixed by #47
Assignees
@peterctl
Labels
enhancement New feature or request

Comments

@LCVcode
Copy link
Owner

LCVcode commented Mar 7, 2024

Regex-based filter modes should be added and able to work with all Juju object types. Likely new filters are "regex include" and "regex exclude" (these names can be changed) and possibly more. This may require modification of existing filter mode strings, which is expected.
@johnlettman johnlettman added the enhancement New feature or request label Mar 15, 2024
@LCVcode
Copy link
Owner Author

LCVcode commented Mar 21, 2024

Filter codes will likely be changed when this is implemented. Be sure to update the example queries in README.md to reflect these changes, including adding new examples to demonstrate regex filtering.

johnlettman added a commit to johnlettman/pr-jockey that referenced this issue Aug 20, 2024
@johnlettman
fix LCVcode#1 add regex filters
7445761
@johnlettman johnlettman mentioned this issue Aug 20, 2024
Closed
@johnlettman johnlettman linked a pull request Aug 20, 2024 that will close this issue
Add regular expression filters #42
Closed
johnlettman added a commit to johnlettman/pr-jockey that referenced this issue Aug 25, 2024
@johnlettman
[no ci] WIP: major sync LCVcode#38 LCVcode#37 LCVcode#36 LCVcode#21 L…
44c481c 
…CVcode#20 LCVcode#1
@johnlettman johnlettman linked a pull request Sep 2, 2024 that will close this issue
Refactor: Remote Juju and complex caching #47
Merged
LCVcode pushed a commit that referenced this issue Sep 2, 2024
@johnlettman
Refactor: Remote Juju and complex caching (#47)
133f462 
* status_keeper.py: use XDG specification paths for cache and config

* status_keeper.py: create directories if they do not exist with XDG

* status_keeper.py: remove redundant path check

* status_keeper.py: remove unreachable return in get_current_juju_status_json

* juju_schema: add new schema-based types workflow per #38

* status_keeper.py: use XDG specification paths for cache and config

* status_keeper.py: create directories if they do not exist with XDG

* status_keeper.py: remove redundant path check

* status_keeper.py: remove unreachable return in get_current_juju_status_json

* fix isort on branch

* #37 #36 add remote API and complex caching

* expand caching, logging, and args

* rename cache -> caching

* [no ci] .gitignore: ignore manpages

* [no ci] WIP: major sync #38 #37 #36 #21 #20 #1

* add forgotten cloud.py ...

* [no ci] .gitignore: ignore generated setup.py

* abstractions: add is_valid() funcs

* abstractions: add docs

* abstractions: typo: double-space

* [no ci] relocate test samples

* juju: add machine functions, fix broken sub-unit refs to machines

* objects: add machines, add __repr__

* filters: FilterMode: more efficient abstract funcs

* objects: Object: more efficient abstract funcs

* objects: Object: tokens -> set

* tests: add objects

* tests: remove object_types

* juju: remove unused funcs

* filters: fix error in args to not_regex_filter

* filters: -> sets in tokens and bool_parser

* filters: tidy type parsing

* filters: use reasonable inference for `should_convert`

* filters: add prior import for inference

* [no ci] abstractions, filters: formatting

* [no ci] __init__: fix license and copyright

* cache: consolidate into Reference

* cache: normalize names

* tests: add cache

* tests: remove getters

* tests: add abstractions

* filters: FilterType: remove `should_parse`

* tests: refactor filters

* tests: refactor objects

* fix merge errors, update deps

* fix `requires-python`

* [no ci] (cql) main: fix commented-out code

* (cql) abstractions: fix inconsistent

* (cql) cache: fixed unused import

* (cql) cloud: fixed unused import

* (cql) filters: fix unused import

* (cql) help: remove broken func

* post-merge lock update

* post-merge lint

* fix flake8 errors

* fix tests

* fix missing samples in tests

* pyproject.toml: revert manpages changes

* ci: add test reports

* ci: remove typo

* ci: fix report limiting

* ci: fix PR permissions

* ci: fix PR permissions

* ci: ignore errors in PR comments

* tests: move `SAMPLES_DIR` to util

* filters: greedy match tokens on EQUALS

* tests: add CLI tests

* [no ci] drop core.py

* filters: prefer greedy match on tokens

* tests: add CLI machine test

* pytest: bump report verbosity

* (cql) filters: fix lambda and unpacking types

* (cql) tests/util: add eq and ne funcs to StandardOutputCapture

* filters: handle key errors on actions

* wip: Sphinx support

* filters: add full docs

* cache: add full docs

* [no ci] abstractions: add full docs

* [no ci] cache: add module docstring

* [no ci] juju: add module docs

* [no ci] objects: add module docs

* [no ci] juju: docs use active verbs

* [no ci] docs: remove sphinx-pyproject

* v. bump 0.1.0 -> 0.2.0

* [no ci] ci: fix docs

* objects: fix __str__

* objects: fix __str__ tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterctl peterctl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@peterctl @johnlettman @LCVcode