Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation needed for get/setCustomParameters #65

Closed
kmdouglass opened this issue Jan 22, 2018 · 2 comments
Closed

Better documentation needed for get/setCustomParameters #65

kmdouglass opened this issue Jan 22, 2018 · 2 comments

Comments

@kmdouglass
Copy link
Member

These methods are part of the ImageGenerator interface but it's not quite clear what they're used for from the Javadocs.

@MStefko
Copy link
Contributor

MStefko commented Jan 23, 2018

Thinking about it, these methods have no business being part of the interface. These methods should be removed, and any implementation should be refactored into class-specific methods. E.g. if an implementation uses setCustomParameters("laser_power", value), it should be refactored into its own method setLaserPower(value).

@MStefko
Copy link
Contributor

MStefko commented Jan 23, 2018

See #66

@MStefko MStefko closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants