Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLIC: Populate rank and count earlier #1410

Closed
white238 opened this issue Sep 16, 2024 · 4 comments
Closed

SLIC: Populate rank and count earlier #1410

white238 opened this issue Sep 16, 2024 · 4 comments
Assignees
Labels
Reviewed Slic Issues related to Axom's 'slic' component User Request Issues related to user requests

Comments

@white238
Copy link
Member

From @gberg617:

I was noticing that the rank information (both list of ranks and count) are populated for Lumberjack streams only when pushing the messages. Do you know if it would be possible at all to populate this information for ranks that are going call outputLocal and then abort? No need to go out of your way if you think this will be difficult to change, but I was curious if it's something that could be a
simple few lines of code changes.

@white238 white238 added Slic Issues related to Axom's 'slic' component User Request Issues related to user requests labels Sep 16, 2024
@bmhan12
Copy link
Contributor

bmhan12 commented Sep 16, 2024

@gberg617
My initial thought was I expected the rank information to be present for outputLocal, since we are testing for it in our unit tests.

Looks like we are not checking the rank information yet in our unit tests.

I'll add unit tests, and see if I get the same missing-rank-information behavior.

@bmhan12 bmhan12 self-assigned this Sep 16, 2024
@bmhan12
Copy link
Contributor

bmhan12 commented Sep 23, 2024

@gberg617

So I am encountering errors in terms of unexpected rank/rank count information when I added unit tests (branch: bugfix/han12/slic_rank_info)
Still in the process of debugging what/where the issue is from...

@gberg617
Copy link

@gberg617

So I am encountering errors in terms of unexpected rank/rank count information when I added unit tests (branch: bugfix/han12/slic_rank_info) Still in the process of debugging what/where the issue is from...

Thanks for the update!

@bmhan12
Copy link
Contributor

bmhan12 commented Sep 30, 2024

@gberg617
I added rank and rank count unit tests in PR #1431.
The error I was running into was strictly Axom-related, involving std::ends (PR has more details).

In terms of rank and rank count, I did not notice the information missing on outputLocalMessages() calls.

I did want to reiterate that for outputLocalMessages() the messages do not get combined, as that is a collective operation that does not bode well when trying to MPI_Abort().
So its expected that the messages will only contain information for the current rank (e.g. Rank 0's message will have rank: 0 rank_count:1 , Rank 1's message will have rank: 1 rank_count: 1, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Slic Issues related to Axom's 'slic' component User Request Issues related to user requests
Projects
None yet
Development

No branches or pull requests

4 participants