Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustness problem in primal intersection test #1468

Open
gunney1 opened this issue Nov 7, 2024 · 0 comments
Open

Robustness problem in primal intersection test #1468

gunney1 opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working low priority Primal Issues related to Axom's 'primal component Reviewed

Comments

@gunney1
Copy link
Contributor

gunney1 commented Nov 7, 2024

I found failures in the test ./tests/primal_intersect_test --gtest_filter=*triangle_segment_intersection.

The specific case has the label "beyond corner" in file primal_intersect.cpp. We test a triangle-segment intersection where the intersection is right at a corner of the triangle. The results depend on the round-off error, but the test expects an intersection. The test should be robust enough to allow for intersection or not, and maybe check that the closest distance is within some epsilon for these cases.

I don't think this failure would affect applications, but to head off false positives, it should be fixed. Hence, I'm labeling it low priority. I have the configuration that can reproduce this bug, but it's a horrendously long Spack-generated cmake command.

@gunney1 gunney1 added bug Something isn't working Primal Issues related to Axom's 'primal component low priority labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Primal Issues related to Axom's 'primal component Reviewed
Projects
None yet
Development

No branches or pull requests

2 participants