Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address remaining issues with MFEMSidreDataCollection #355

Open
3 of 4 tasks
joshessman-llnl opened this issue Sep 25, 2020 · 5 comments
Open
3 of 4 tasks

Address remaining issues with MFEMSidreDataCollection #355

joshessman-llnl opened this issue Sep 25, 2020 · 5 comments
Assignees
Labels
Reviewed Sidre Issues related to Axom's 'sidre' component Spio Issues related to paralle I/O for Axom's Sidre component TPL Issues related to Axom's third party libraries Windows Related to Windows development

Comments

@joshessman-llnl
Copy link
Member

joshessman-llnl commented Sep 25, 2020

#318 moves the SidreDataCollection class from MFEM into Axom, but the feature is not enabled by default. Before this can be enabled, the following issues need to be addressed (per @kennyweiss):

@joshessman-llnl joshessman-llnl added Sidre Issues related to Axom's 'sidre' component TPL Issues related to Axom's third party libraries Spio Issues related to paralle I/O for Axom's Sidre component Windows Related to Windows development labels Sep 25, 2020
@joshessman-llnl
Copy link
Member Author

We should also look into eliminating the requirement that meshes/fields be explicitly constructed as "owned" by the datastore, see #379 (comment)

@joshessman-llnl
Copy link
Member Author

Once reconstruction for parallel meshes is implemented we should look at ensuring coherency between the mfem::Mesh object and the contents of the datastore as refinement can cause them to diverge.

@rhornung67
Copy link
Member

We should also look into eliminating the requirement that meshes/fields be explicitly constructed as "owned" by the datastore, see #379 (comment)

@joshessman-llnl we support this capability already if I understand your point. Indeed, this is how Miranda uses Sidre in MARBL.

@white238
Copy link
Member

Random info to help finish this issue off:

convert_sidre_protocol is not being built in the Github Actions windows CI because MPI is off.

https://github.com/LLNL/axom/actions/runs/4120664761/jobs/7115614836#step:8:42

@rhornung67 rhornung67 removed this from the FY25 Development milestone Jan 13, 2025
@rhornung67
Copy link
Member

Close and move third checkbox to new issue.

Note issue about relying on MFEM internals in implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Sidre Issues related to Axom's 'sidre' component Spio Issues related to paralle I/O for Axom's Sidre component TPL Issues related to Axom's third party libraries Windows Related to Windows development
Projects
None yet
Development

No branches or pull requests

4 participants