Construct shapes in memory and support more shapes #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds test code for testing in-memory shape construction and shaping with those objects.
Fix by changing the pointer references to shared_ptr references. This bug was recently created when factoring out the generation of the mesh so it can be saved outside the scope it was generated in.
…ct-shapes-in-memory
…ct-shapes-in-memory
to ensure the user provided a blueprint mesh.
gunney1
added
Quest
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
rhornung67
reviewed
Oct 11, 2024
8 tasks
The feature was never used and we are moving away from MFEM mesh in favor of blueprint mesh.
bmhan12
reviewed
Oct 15, 2024
This was referenced Oct 21, 2024
…ct-shapes-in-memory
…ct-shapes-in-memory
…ond to direction. Multiple shape tests checks the mechanism for saving some mesh-dependent but not shape-dependent data between calls to the shaper. Letting some shapes change direction makes the test a bit less trivial.
Want to avoid having small ones that aren't well resolved with a coarse mesh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is one of several steps toward extending support for shaping on GPUs and exending the menu of shapes supported.
IntersectionShaper#1446 and will be worked on in separate PR.) In this PR, we just make changes to work withArrayViewinstead of directly with the MFEM mesh interface.This PR is a first pass at this capability. We would like to get something working asap for an application requirement. We will revisit the interface and performance by Spring 2025. See issue #1445.