features/branson #462
Open
features/branson #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfhaque
commented
Dec 1, 2024
repo/branson/package.py
Outdated
Comment on lines
71
to
76
| cflags = " ".join(self.compiler.flags['cflags']) if 'cflags' in self.compiler.flags else "" | ||
| cxxflags = " ".join(self.compiler.flags['cxxflags']) if 'cxxflags' in self.compiler.flags else "" | ||
|
|
||
| args.append("-DCMAKE_C_FLAGS={} -I{}/src/random123/features".format(cflags, self.stage.source_path)) | ||
| args.append("-DCMAKE_CXX_FLAGS={} -I{}/src/random123/features".format(cxxflags, self.stage.source_path)) | ||
| args.append(f"-DBUILD_TESTING=OFF") |
There was a problem hiding this comment.
@pearce8 This is just a temporary fix for lassen. Need to work with the branson team to fix build issues on that system.
There was a problem hiding this comment.
I'll look at the RNG package again and see if an update fixes this.
added 6 commits
January 2, 2025 19:39
|
@rfhaque Please update: which machines does the code work on? What are the outstanding items to fix? |
The code works on all the LC systems (ruby, lassen, tioga) and on the LANL venado system. Once the cmake changes are upstreamed to the branson repo, we can merge this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a specification of Branson https://lanl.github.io/benchmarks/01_branson/branson.html.
We should work with @gshipman and @alexrlongne to make progress on incorporating Branson.
application.pyand (maybe)package.pyunder a new directory for this benchmarkexperiment.py.github/workflowsunit tests (if needed)