Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix News publication dates #675

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Fix News publication dates #675

merged 1 commit into from
Mar 29, 2024

Conversation

dpfens
Copy link
Contributor

@dpfens dpfens commented Mar 29, 2024

Closes #655 by changing how JS parses publication dates. For details on cross-browser JS parsing inconsistencies see Stack Overflow

@dpfens dpfens requested a review from a team as a code owner March 29, 2024 16:06
@hauten
Copy link
Contributor

hauten commented Mar 29, 2024

@dpfens Locally, the day of the month is correct, but the month is one ahead of the real month. Example: 2024-03-21-flux.md appears as April 21, 2024 instead of March 21, 2024. (The 21 is correct now; it used to display as 20.)

for details, see https://stackoverflow.com/a/31732581 regarding inconsistent parsing of date strings in Javascript
@dpfens
Copy link
Contributor Author

dpfens commented Mar 29, 2024

@hauten thanks for catching that. It's now corrected.

@hauten hauten merged commit 5b60c6a into LLNL:main Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

News date displays a day earlier than the post date
2 participants