Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default ARKODE methods #547

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

Conversation

Steven-Roberts
Copy link
Collaborator

@Steven-Roberts Steven-Roberts commented Jul 26, 2024

Replaces #345

In draft status until we settle on the defaults. Then I'll update the docs and output files.

Justification:

  • ARK order >2: Follows the recommendations in the conclusion of https://doi.org/10.1016/j.apnum.2018.10.007
  • ERK order 4: Improved principal error and embedded quality metrics
  • ERK order 5: Improved principal error and embedded quality metrics
  • ERK order 8: Switch to a method designed for local extrapolation mode. Likely better principal error but need to confirm
  • IRK order 2: Improved principal error, L-stability, and stage order 2
  • IRK order >2: Follows the recommendations in the conclusion of https://doi.org/10.1016/j.apnum.2019.07.008

@drreynolds drreynolds mentioned this pull request Sep 5, 2024
drreynolds added a commit that referenced this pull request Sep 6, 2024
@Steven-Roberts Steven-Roberts marked this pull request as ready for review September 8, 2024 06:31
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Constants.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Constants.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
@balos1 balos1 added this to the SUNDIALS Next milestone Sep 12, 2024
@Steven-Roberts
Copy link
Collaborator Author

@gardner48 @drreynolds can you confirm this is the table format you're looking for:
https://sundials--547.org.readthedocs.build/en/547/arkode/Butcher_link.html#id61

If that looks good, I'll do the same for DIRK and SPRK (MRI already exists). I'll also remove all the corresponding constants from Constants.rst.

@gardner48
Copy link
Member

@gardner48 @drreynolds can you confirm this is the table format you're looking for: https://sundials--547.org.readthedocs.build/en/547/arkode/Butcher_link.html#id61

If that looks good, I'll do the same for DIRK and SPRK (MRI already exists). I'll also remove all the corresponding constants from Constants.rst.

Yes, that's what I was thinking

@balos1 balos1 modified the milestones: SUNDIALS Next, SUNDIALS Next^2 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants