Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether aiapy.psf uses the GPU/cupy or not is opaque #84

Open
nabobalis opened this issue Feb 2, 2021 · 1 comment
Open

Whether aiapy.psf uses the GPU/cupy or not is opaque #84

nabobalis opened this issue Feb 2, 2021 · 1 comment
Labels

Comments

@nabobalis
Copy link
Contributor

In GitLab by @wtbarnes on Feb 2, 2021, 08:50

Currently, in aiapy.psf.psf and aiapy.psf.deconvolve, cupy is used if it is installed and if use_gpu is set to True. This is a bit opaque to users and is somewhat dangerous as it potentially means a result is dependent on someone's environment and this may be very non-obvious.

Perhaps a better solution should be to use cupy only if the input map data is a cupy array. This would make it much more clear to users they are using cupy. This is slightly more tricky for the PSF calculation as there is no input array, but maybe the current interface would suffice for that function.

This may also require an upstream fix in sunpy that allows map data to be a cupy array.

@nabobalis
Copy link
Contributor Author

In GitLab by @wtbarnes on Apr 30, 2021, 05:41

changed health status to needs attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant