You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, in aiapy.psf.psf and aiapy.psf.deconvolve, cupy is used if it is installed and if use_gpu is set to True. This is a bit opaque to users and is somewhat dangerous as it potentially means a result is dependent on someone's environment and this may be very non-obvious.
Perhaps a better solution should be to use cupy only if the input map data is a cupy array. This would make it much more clear to users they are using cupy. This is slightly more tricky for the PSF calculation as there is no input array, but maybe the current interface would suffice for that function.
This may also require an upstream fix in sunpy that allows map data to be a cupy array.
The text was updated successfully, but these errors were encountered:
In GitLab by @wtbarnes on Feb 2, 2021, 08:50
Currently, in
aiapy.psf.psf
andaiapy.psf.deconvolve
, cupy is used if it is installed and ifuse_gpu
is set toTrue
. This is a bit opaque to users and is somewhat dangerous as it potentially means a result is dependent on someone's environment and this may be very non-obvious.Perhaps a better solution should be to use cupy only if the input map data is a cupy array. This would make it much more clear to users they are using cupy. This is slightly more tricky for the PSF calculation as there is no input array, but maybe the current interface would suffice for that function.
This may also require an upstream fix in sunpy that allows map data to be a cupy array.
The text was updated successfully, but these errors were encountered: