Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aiapy.calibrate.register to accept submaps #99

Open
nabobalis opened this issue Jul 9, 2021 · 1 comment
Open

Allow aiapy.calibrate.register to accept submaps #99

nabobalis opened this issue Jul 9, 2021 · 1 comment

Comments

@nabobalis
Copy link
Contributor

In GitLab by @wtbarnes on Jul 9, 2021, 05:09

Currently, register will throw an exception if you try to pass it anything but a full-disk image. This is because of the way register uses the underlying rotate method on sunpy.map.Map. We should figure out how to relax this assumption (maybe it does already work??).

A simple test would be to call register on a full disk map and then do a cutout, and then do the operation in reverse order (i.e. cutout, register) and compare the two. Where are they different? why? If implemented, this should become a test.

This would be a great feature to have as it would mean one can "prep" cutouts from the JSOC. As it stands right now, to do cross-channel alignment, one has to retrieve full-disk images.

@nabobalis
Copy link
Contributor Author

In GitLab by @wtbarnes on Feb 7, 2023, 08:49

There is also the question of why update_pointing does not accept submaps either. Currently, this is because the reference pixel is computed assuming that the map has (4096,4096) pixels. However, there's no reason that this couldn't be then translated appropriately to the frame of the submap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant