Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-square matrix types #3

Open
LPGhatguy opened this issue Sep 22, 2020 · 0 comments
Open

Non-square matrix types #3

LPGhatguy opened this issue Sep 22, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@LPGhatguy
Copy link
Owner

LPGhatguy commented Sep 22, 2020 •
edited
Loading

This creates a bit of a blow-up to the number of types in the crate. I'm unsure how we'll organize and verify them for correctness.
@LPGhatguy LPGhatguy added the enhancement New feature or request label Sep 22, 2020
@LPGhatguy LPGhatguy mentioned this issue Oct 18, 2020
Merged
LPGhatguy added a commit that referenced this issue Oct 18, 2020
@LPGhatguy
Merge pull request #9 from LPGhatguy/please-sir-may-i-have-some-align…
969f4b9 
…ment

Closes #4.

This PR does a couple things that are intertwined. I'll try to explain each thing and why it's tangled with the others!

First, I added support for structs with alignment over 16 bytes. Thanks to @benmkw in [this comment](#1 (comment)) for pointing out this need!

In order to write sufficient tests for that increased alignment, I needed base types with alignment greater than 16. Instead of adding fake types, I added the double types that we already wanted anyways. I'm not 100% sure about the layout of the double-based matrix types and would love some extra review.

In order to add the new vector and matrix types, I decided it was probably time to switch the vector and matrix declarations to use a macro. I figure this will be useful as part of #3 as well in the future, as well as if/when we introduce the int and bool-based vectors and matrices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LPGhatguy