Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement typing #12

Open
arthurmloureiro opened this issue Oct 25, 2024 · 0 comments · May be fixed by #13
Open

Implement typing #12

arthurmloureiro opened this issue Oct 25, 2024 · 0 comments · May be fixed by #13
Assignees
@arthurmloureiro
Labels
👑 🔥 Firecrown Issues related to firecrown 📄 documentation Improvements or additions to documentation

Comments

@arthurmloureiro
Copy link
Collaborator

Add type hinting to the functions to keep consistency with Firecrown.
@arthurmloureiro arthurmloureiro added 📄 documentation Improvements or additions to documentation 👑 🔥 Firecrown Issues related to firecrown labels Oct 25, 2024
@arthurmloureiro arthurmloureiro self-assigned this Oct 25, 2024
arthurmloureiro added a commit that referenced this issue Oct 25, 2024
@arthurmloureiro
Implement typing
774b601 
Fixes #12

Add type hinting to various functions across multiple files for consistency with Firecrown.

* **`CosmoAPI/two_point_functions/generate_theory.py`**
  - Add type hints to `generate_ell_theta_array_from_yaml`, `load_systematics_factory`, `process_probes_load_2pt`, `generate_two_point_metadata`, and `prepare_2pt_functions`.

* **`CosmoAPI/two_point_functions/nz_loader.py`**
  - Add type hints to `_load_nz`, `load_all_nz`, and `_load_nz_from_module`.

* **`CosmoAPI/__main__.py`**
  - Add type hints to `gen_datavec`, `gen_covariance`, `forecast`, and `main`.

* **`CosmoAPI/api_io.py`**
  - Add type hints to `load_yaml_file` and `load_metadata_function_class`.

Important: Change the placeholder `Any` for the actual firecrown types.
@arthurmloureiro arthurmloureiro linked a pull request Oct 25, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurmloureiro arthurmloureiro

Labels
👑 🔥 Firecrown Issues related to firecrown 📄 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement typing LSSTDESC/CosmoAPI
1 participant
@arthurmloureiro