Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking does not appear to be working for int32 maps with sentinel -2147483648 #51

Open
erykoff opened this issue Nov 7, 2023 · 1 comment

Comments

@erykoff
Copy link
Collaborator

erykoff commented Nov 7, 2023

I think that the isclose check to the sentinel should only be used for floats; we should use exact equality for integer maps.

@erykoff
Copy link
Collaborator Author

erykoff commented Nov 7, 2023

Or there may be a different problem with the map I'm looking at ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant