Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create manifest.json #685

Closed
wants to merge 1 commit into from
Closed

Create manifest.json #685

wants to merge 1 commit into from

Conversation

NiceRecord
Copy link
Contributor

@NiceRecord NiceRecord commented Sep 1, 2023 •
edited
Loading

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot requested changes Sep 1, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Servername has to be directory name!

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

NiceRecord
NiceRecord commented Sep 1, 2023
View reviewed changes
Copy link
Contributor Author

@NiceRecord NiceRecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add background.png
background

NiceRecord
NiceRecord commented Sep 1, 2023
View reviewed changes
Copy link
Contributor Author

@NiceRecord NiceRecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minecraft_servers/Nice-City/background.png
background

@l3nnartt
Copy link
Contributor

l3nnartt commented Sep 3, 2023

Hey, you need to add the files in your fork and not here as a comments
If you need help with this, hit me up.

@JakobBruening
Copy link
Member

Four failed PRs from you. I will close everything.
Please re-submit a correct PR. If you need help, feel free to contact us but please prevent spamming wrong PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NiceRecord @l3nnartt @JakobBruening