Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental buttonless service #31

Open
algrm opened this issue Mar 22, 2024 · 0 comments
Open

Experimental buttonless service #31

algrm opened this issue Mar 22, 2024 · 0 comments

Comments

@algrm
Copy link

algrm commented Mar 22, 2024

Describe the bug
EnableUnsafeExperimentalButtonlessServiceInSecureDfu parameter has no effect on iOS.

Looking at /Laerdal.Dfu/iOS/DfuInstallation.cs, line 60:

// EnableUnsafeExperimentalButtonlessServiceInSecureDfu
if (EnableUnsafeExperimentalButtonlessServiceInSecureDfu.HasValue)
    Initiator.ForceScanningForNewAddressInLegacyDfu = EnableUnsafeExperimentalButtonlessServiceInSecureDfu.Value;

It should be:

// EnableUnsafeExperimentalButtonlessServiceInSecureDfu
if (EnableUnsafeExperimentalButtonlessServiceInSecureDfu.HasValue)
    Initiator.EnableUnsafeExperimentalButtonlessServiceInSecureDfu = EnableUnsafeExperimentalButtonlessServiceInSecureDfu.Value;

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant