Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord messages not being sent promptly to game #121

Open
trevorjd opened this issue Dec 31, 2021 · 6 comments
Open

Discord messages not being sent promptly to game #121

trevorjd opened this issue Dec 31, 2021 · 6 comments
Assignees
Labels

Comments

@trevorjd
Copy link

Hi Lake,

I noticed this problem with our first version of 7D2D-Discord and again with the RC2 Dishorde. Messages entered in Discord are not always sent promptly to game. I got into a habit of sending a second line with just "." but I caught it in action tonight so thought I'd log an issue.

I sent a message (the reply to Jame) at 10:26pm but it wasn't sent until I sent another message just now (a few mins before midnight). I notice that it also doubled a current message. (image link has more info)

Please forgive the unkind words. It's almost midnight and I'm on the Bacardi now. May your 2022 be bug-free! (Yeah I know, but we can hope!)

https://i.imgur.com/f4Ggw5p.png

@LakeYS LakeYS self-assigned this Dec 31, 2021
@LakeYS LakeYS added the bug label Dec 31, 2021
@LakeYS
Copy link
Owner

LakeYS commented Dec 31, 2021

Will add some tests for this in the next rc build.

@trevorjd
Copy link
Author

trevorjd commented Jan 1, 2022

Installed 2.0.0.rc3 about 2 hrs ago. So far so good, haven't noticed any dupes. However I have noticed that the delay on sending from Discord to game is worse. Pretty much every message I send now gets "buffered" and requires me to send another to kick it through. Killing and restarting Dishorde sorts it out.

@LakeYS
Copy link
Owner

LakeYS commented Jan 3, 2022

Can you grab any logs with debug-mode turned on when the "buffering" issue happens?

Edit: Logs were sent to me via Discord, here's the highlight:

image

This would link this problem with #118, meaning both issues may have the same root cause.

@LakeYS
Copy link
Owner

LakeYS commented Jan 17, 2022

Have yet to encounter any more of the buffering issue, but I did manage to catch a message not going through at all. I will look into the current logs/detection accordingly.

We could possibly add a message for this. I.e. a temporary, self-deleting message that says something like "Could not send your message to the server".

@trevorjd
Copy link
Author

Still happening for us. I have disable-non-player-chatmsgs set false so that we get an echo back. That's helpful as it shows us pretty quickly whether the message went through. If it doesn't, we can send a dummy line through to "flush the buffer" as it were.

Interestingly, I just tried capturing some more debug data, first time on 2.0.0. I have the three 3 debug options set true but it's not generating a log file, so that's something to look at.

I did notice that the debug info coming up on the console doesn't include any timestamps nor indication on what it's processing. Perhaps you could add a trace-discord-message option that produces a report like:

Message received from Discord
Sender: Trevor#1234
Msg length: 24
Msg content: blah blah blah
Delivered to game: success / failure

Not practical to do it for messages coming from game though.

Example of a delayed message (and the very-helpful echo!) from just now: https://i.imgur.com/Im3HvFg.png

@EvilBurrito
Copy link

I am having the same issue when the text is over a certain character limit. I would have to do more testing and enable debug mode to see what that limit seems to be. I only have chat messages enabled. It is only when the message is sent from Discord to the game. Other direction works fine with no issues as far as I can tell. As noted by original poster, I follow the message with any other message that is below that character limit and it sends the previous message as well as the 2nd one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants