Skip to content

Latest commit

 

History

History
136 lines (83 loc) · 8.57 KB

CONTRIBUTING.md

File metadata and controls

136 lines (83 loc) · 8.57 KB
Raw

How to Contribute

Operator Controller is an Apache 2.0 licensed project and accepts contributions via GitHub pull requests (PRs).

Certificate of Origin

By contributing to this project you agree to the Developer Certificate of Origin (DCO). This document was created by the Linux Kernel community and is a simple statement that you, as a contributor, have the legal right to make the contribution. See the DCO file for details.

Overview

Thank you for your interest in contributing to the Operator-Controller.

As you may or may not know, the Operator-Controller project aims to deliver the user experience described in the Operator Lifecycle Manager (OLM) V1 Product Requirements Document (PRD). The design requirements captured in the OLM V1 PRD were born from customer and community feedback based on the experience they had with the released version of OLM V0.

The user experience captured in the OLM V1 PRD introduces many requirements that are best satisfied by a microservices architecture. The OLM V1 experience currently relies on two projects:

Each of the projects listed above have their own governance, release milestones, and release cadence. However, from a technical perspective, the "OLM V1 experience" matches the experienced offered by the operator-controller project, the top level component which depends on Catalogd.

How do we collaborate

"We need to accept that random issues and pull requests will show up" - Joe L.

Before diving into our process for coordinating community efforts, I think it's important to set the expectation that Open Source development can be messy. Any effort to introduce a formal workflow for project contributions will almost certainly be circumvented by new community users. Rather than pestering users to subscribe to a project-specific process, we strive to make it as simple as possible to provide valuable feedback. With that in mind, changes to the project will almost certainly follow this process:

  1. The community engages in discussion in the #olm-dev slack channel.
  2. The community creates GitHub Issues, GitHub Discussions, or pull requests in the appropriate repos based on (1) to continue the discussion.
  3. The community utilizes the Working Group Meeting to talk about items from (1) and (2) as well as anything else that comes to mind.

The workflow defined above implies that the community is always ready for discussion and that ongoing work can be found in the GitHub repository as GitHub Issues, GitHub Discussions, or pull requests, and that milestone planning is async, happening as part of (1), (2), and (3).

Please keep this workflow in mind as you read through the document.

How to Build and Deploy Locally

After creating a fork and cloning the project locally, you can follow the steps below to test your changes:

  1. Create the cluster:

    kind create cluster -n operator-controller

  2. Build your changes:

    make build docker-build

  3. Load the image locally and Deploy to Kind

    make kind-load kind-deploy

Communication Channels

How are Milestones Designed?

It's unreasonable to attempt to consider all of the design requirements laid out in the OLM V1 PRD from the onset of the project. Instead, the community attempts to design Milestones with the following principles:

  • Milestones are tightly scoped units of work, ideally lasting one to three weeks.
  • Milestones are derived from the OLM V1 PRD.
  • Milestones are "demo driven", meaning that a set of acceptance criteria is defined upfront and the milestone is done as soon as some member of the community can run the demo.
  • Edge cases found during development are captured in issues and assigned to the GA Milestone, which contains a list of issues that block the release of operator-controller v1.0.0 .

This "demo driven" development model will allow us to collect user experience and regularly course correct based on user feedback. Subsequent milestone may revert features or change the user experience based on community feedback.

The project maintainer will create a GitHub Discussion for the upcoming milestone once we've finalized the current milestone. Please feel encouraged to contribute suggestions for the milestone in the discussion.

Where are Operator Controller Milestones?

Ongoing or previous Operator-Controller milestones can always be found in the milestone section of our GitHub Repo.

How are Subproject Issues Tracked?

As discussed earlier, the operator-controller adheres to a microservice architecture, where multiple projects contribute to the overall experience. As such, when designing an operator-controller milestone, the community may need to file an issue against Catalogd. Unfortunately, the operator-controller milestone cannot contain issues from one of its subprojects. As such, we've introduced the concept of a "Dependency Issue", described below:

Dependency Issues: An issue tracked in a milestone that "points" to an issue in another project with a URL.

Submitting Issues

Unsure where to submit an issue?

Don't worry if you accidentally submit an issue against the wrong project, if we notice that an issue would fit better with a separate project we'll move it to the correct repository and mention it in the #olm-dev slack channel.

Submitting Pull Requests

Code Review

Contributing PRs with a reasonable title and description can go a long way with helping the PR through the review process.

When opening PRs that are in a rough draft or WIP state, prefix the PR description with WIP: ... or create a draft PR. This can help save reviewer's time by communicating the state of a PR ahead of time. Draft/WIP PRs can be a good way to get early feedback from reviewers on the implementation, focusing less on smaller details, and more on the general approach of changes.

When contributing changes that require a new dependency, check whether it's feasible to directly vendor that code without introducing a new dependency.

Currently, PRs require at least one approval from an operator-controller maintainer in order to get merged.

Code style

The coding style suggested by the Golang community is used throughout the operator-controller project:

In addition to the linked style documentation, operator-controller formats Golang packages using the golangci-lint tool. Before submitting a PR, please run make lint locally and commit the results. This will help expedite the review process, focusing less on style conflicts, and more on the design and implementation details.

Please follow this style to make the operator-controller project easier to review, maintain and develop.

Documentation

If the contribution changes the existing APIs or user interface it must include sufficient documentation to explain the new or updated features.

The Operator Controller documentation is primarily housed at the root-level README.