Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Mob Database resistances being assigned incorrectly. #7128

Open
3 tasks done
UmeboshiXI opened this issue Feb 23, 2025 · 2 comments
Open
3 tasks done

🐛 Mob Database resistances being assigned incorrectly. #7128

UmeboshiXI opened this issue Feb 23, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@UmeboshiXI
Copy link
Contributor

UmeboshiXI commented Feb 23, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base (Reproduced in vanilla LandSandBoat)

Steps to reproduce

All mobs with a SDT modifier below 1.00 in mob_resistances.sql end up having a corresponding SDT value of 0 ingame (Unmodified damage is 1000 SDT Mod). This causes players to do 0 damage to them.

Another related bug is that any SDT modifier above 1.0 in the DB ends up being 1000 SDT modifier ingame.

Image

Image

Expected behavior

Mobs should have their expected resist modifiers.

@UmeboshiXI UmeboshiXI added the bug Something isn't working label Feb 23, 2025
@UmeboshiXI UmeboshiXI changed the title 🐛 Mob SDT Resistances 🐛 Mob Database resistances being assigned incorrectly. Feb 23, 2025
@Xaver-DaRed
Copy link
Contributor

Time to make those SDT modifiers work like the others

@UmeboshiXI
Copy link
Contributor Author

UmeboshiXI commented Feb 23, 2025

I think it might be related to this: #7104

Comparing new(green) vs old(red):

Image

Image

The DB value is a float but we are now retrieving a uint16(Before multiplying). Then when we multiply it would either be 0 or 1 which lines up with the bug behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants