Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests and add back validation for some agents #747

Merged
merged 10 commits into from
Dec 14, 2023
Merged

Add more tests and add back validation for some agents #747

merged 10 commits into from
Dec 14, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Dec 13, 2023 •
edited
Loading

Summary:

  • add tests for Python sources with big messages
  • add fn:length function
  • add validation for agents with nested collections (like "compute") (the integration tests failed due to a type in the compute agent, but the validation was not working)
  • suppress errors in some shutdown cases for Python agents (they hid the errors in the compute step while I was working on integration tests)
  • fix the validation of EL expressions in the configuration

@eolivelli eolivelli changed the title GRPC agents: relax more limits Add more tests and add back validation for some agents Dec 14, 2023
@eolivelli eolivelli merged commit 3f8538d into main Dec 14, 2023
10 checks passed
@eolivelli eolivelli deleted the more-grpc-limits branch December 14, 2023 16:51
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@eolivelli
Add more tests and add back validation for some agents (LangStream#747)
abedd84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@cbornet cbornet Awaiting requested review from cbornet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eolivelli @cbornet @nicoloboschi