Issue 741 fix #748
Merged
Issue 741 fix #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully this time it's a right place :) |
eolivelli
reviewed
Dec 13, 2023
| import io.fabric8.kubernetes.api.model.VolumeBuilder; | ||
| import io.fabric8.kubernetes.api.model.VolumeMount; | ||
| import io.fabric8.kubernetes.api.model.VolumeMountBuilder; | ||
| import io.fabric8.kubernetes.api.model.*; |
There was a problem hiding this comment.
please do not use star imports
nicoloboschi
approved these changes
Dec 13, 2023
…ign to Agent STS and not App
Dobosz
force-pushed
the
issue_741_fix
branch
from
9b3f318 to
cfc993e
Compare
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
* Revert "[Issue LangStream#741] Add fsGroup for runtime pod (LangStream#743)" This reverts commit 2cd631c. * [Issue LangStream#741] Fixes previous commit. fsGroup will now be assign to Agent STS and not App
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.