Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra dot from breadcrumbs after entity name #5430

Conversation

kamrul-bd
Copy link
Contributor

WHY

Need to remove this extra dot from breadcrumbs in create and edit view.

BEFORE - What was wrong? What was happening before this PR?

There is an extra dot(.) after entity name on breadcrumbs in create and edit view.
dot-issue

AFTER - What is happening after this PR?

Removed the dot from breadcrumbs.

HOW

Just remove the dot(.) from create.blade.php and edit.blade.php

How did you achieve that, in technical terms?

??

Is it a breaking change?

No

How can we test the before & after?

Just check the breadcrumbs in create and edit page.

If the PR has changes in multiple repos please provide the command to checkout all branches, eg.:

git checkout "dev-branch-name" &&
cd vendor/backpack/crud && git checkout crud-branch-name &&
cd ../pro && git checkout pro-branch-name &&
cd ../../..

@karandatwani92
Copy link
Contributor

Hey @kamrul-bd

The "." is not the part of the breadcrumb. I can see, it is placed after the action description which looks fine to me.
I don't see any issue there.

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants