Update page stub to closely match backpack pages #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
reported by a genius here: https://github.com/Laravel-Backpack/DevTools/issues/350
BEFORE - What was wrong? What was happening before this PR?
The page stub was fairly basic, and wasn't consistent in all themes/layouts. Additionally developers would have quite a hard time to replicate our pages with the headers and the container.
AFTER - What is happening after this PR?
I think it's easier to just remove what you don't need, than trying to figure out how to add this stuff.
HOW
How did you achieve that, in technical terms?
Changed the stub file.
Is it a breaking change or non-breaking change?
Non. If developers had the stub published, their custom stub still takes precedence.