Gtk4 breakage #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaserEyess
force-pushed
the
gtk4_breakage
branch
3 times, most recently
from
7cd867a to
0da91be
Compare
In the GObject clean up this was missed, there needs to a member of the type of the parent class in a GObject subclass.
I didn't use this feature, I didn't really understand it either. What I do know is that it gets in the way of GTK4, which is the current goal.
Unused for now
To be added back as a GMenuModel thing, but this was responsible for handingly connection state in the toolbar/main window, i.e. what remotes there were to connect to. Seems strange, that should likely be in the client? Also was responsible for the popup menus in trg-trackers-tree-view (??)
Much work to be done here, some TODOs are placed elsewhere
Unneeded in gtk4, especially with listviews coming
Deprecated in gtk4, but also a final class, so the gtk3 subclassing doesn't work. Breakage: no mimetype file icon (e.g. book, file, media) in torrent tree dialogs. Not a big deal, this will be added back with columnviews anyway.
This removes right click menus and messes with some formatting. State selector needs to be completely re-imagined soon anyway.
This set up a right click menu for clicking on files. No menus, so we have to get rid of this.
LaserEyess
force-pushed
the
gtk4_breakage
branch
from
a499d1c to
a5a1a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking PR for all GTK4 related changes. This will be messy and it won't compile for a while.